CI: Update build and release dependencies to be referenced by SHA #9177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed using StepSecurity Signed-off-by: StepSecurity Bot <[email protected]>
…sses Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
…ashes Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
The flag is needed to create hash-pinned requirements for pip and setup-tools. Find more information about this at these issues from [pip-tools](jazzband/pip-tools#806) and from [pip](pypa/pip#6459). Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
|
CI seems unhappy. Once it's green I'll review. Thanks for working on this! |
…teps Using the actions/checkout to download the requirements.txt was erasing some necessary files that came from previous steps. Thus, this commit changes moves the checkout action to the beginnig of the jobs. Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
|
CI passing now! It was a problem with a misplaced actions/checkout call that was erasing files created by previous steps. That said, I choose to use this actions/checkout to get the requirements.txt from the repository, taking into account the exact same commit/version that is being run at the CI. If you have any better ideas on how to do it, let me know and I'd be happy to review and refactor my changes. |
|
I've got this on my TODO to review this evening. Thanks
…On Wed, Jul 5, 2023 at 2:18 PM diogoteles08 ***@***.***> wrote:
CI passing now! It was a problem with a misplaced actions/checkout call that was erasing files created by previous steps.
That said, I choose to use this actions/checkout to get the requirements.txt from the repository, taking into account the exact same commit/version that is being run at the CI. If you have any better ideas on how to do it, let me know and I'd be happy to review and refactor my changes.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
reaperhulk
reviewed
Jul 6, 2023
alex
reviewed
Jul 7, 2023
…m code Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
…uild requirements file Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
diogoteles08
force-pushed
the
ci/hash-pin-build-dependencies
branch
from
beaba75 to
916a9bc
Compare
Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
Moved from .github/workflows/requirements/ to .github/requirements/ Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
…relation Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
… pyproject.toml Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
reaperhulk
reviewed
Jul 10, 2023
When calling actions/checkout , we were passing the `ref` parameter as `github.ref`, but it will likely be always main, or the vary same value as the default for this parameter.
reaperhulk
approved these changes
Jul 11, 2023
|
Thanks for working on this @diogoteles08 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of second part of the issue #9073