support setting more PKCS12 serialization encryption options #7560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reaperhulk
force-pushed
the
pkcs12-serialization-2
branch
2 times, most recently
from
d377d46 to
00921fa
Compare
alex
reviewed
Sep 4, 2022
reaperhulk
force-pushed
the
pkcs12-serialization-2
branch
9 times, most recently
from
575df0b to
342534a
Compare
This is limited support, but makes it possible to set two different PBES choices as well as set KDF rounds and MAC algorithm
reaperhulk
force-pushed
the
pkcs12-serialization-2
branch
from
342534a to
9d2567b
Compare
This was
linked to
issues
Sep 5, 2022
alex
reviewed
Sep 5, 2022
Co-authored-by: Alex Gaynor <[email protected]>
alex
reviewed
Sep 5, 2022
Co-authored-by: Alex Gaynor <[email protected]>
alex
approved these changes
Sep 5, 2022
schwabe
reviewed
Sep 5, 2022
| ... kdf_rounds(50000). | ||
| ... key_cert_algorithm(pkcs12.PBES.PBESv1SHA1And3KeyTripleDESCBC). | ||
| ... hmac_hash(hashes.SHA1()).build(b"my password") | ||
| ... ) |
There was a problem hiding this comment.
I am not sure if the parenthesis here serve any purpose. I think Python just ignores them but some might confuse them to put the encryption into a tuple. But then again if you confuse that, you probably should not be playing with these things ...
Edit, nevermind. It allows you to skip all the \.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is limited support, but makes it possible to set different PBES choices as well as set KDF rounds and MAC algorithm.