Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Session functions, necessary to implement new features in Python 3.6 #4205

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

amauryfa
Copy link
Contributor

This change was already applied in the PyPy repository, and test_ssl passes.

@alex
Copy link
Member

alex commented Apr 23, 2018

Looks like there's a compilation error on some OpenSSL versions.

@reaperhulk
Copy link
Member

It appears to fail on any version of OpenSSL < 1.1.0 because the fallback getters attempt to access struct elements that don't exist. In < 1.1.0 they were named tlsext_tick and tlsext_tick_lifetime_hint so the functions need to be modified for that.

@amauryfa
Copy link
Contributor Author

Updated. The tests pass now.

@reaperhulk reaperhulk merged commit c81df6b into pyca:master Apr 24, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants