Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Fixes #3548 - add a pyproject.toml #3610

Closed
wants to merge 6 commits into from
Closed

Conversation

alex
Copy link
Member

@alex alex commented May 25, 2017

Don't merge until PIP X is out.

@alex alex assigned dstufft and unassigned dstufft May 25, 2017
@alex alex requested a review from dstufft May 25, 2017 23:06
@alex alex modified the milestone: Twentieth release May 25, 2017
@alex
Copy link
Member Author

alex commented Apr 8, 2018

pip x comes out in a week. I'd like to make a radical proposal:

  1. We drop setup_requires entirely from our setup.py; with pip x you'll get cffi installed, if you're on an older pip or setuptools you can either upgrade to pip x or manually install cffi
  2. We make setup.py error cleanly if you don't have cffi installed, telling you about (1)
  3. We delete all the wild code for disabling setup_requires if the setup.py command doesn't need it.

Reasons:

  1. Encourage people to upgrade to pip x
  2. Working around this is easy, just pip install cffi>1.7 if you can't upgrade pip for any reason
  3. Let's us delete tons of obscure code
  4. Helps kill off easy_install once and for all, thus protecting against scenarios like "using macOS<10.13 with system python and pip install cryptography successfully downloads cryptography, but then installing it fails to download cffi since that download is done by setuptools"

@reaperhulk
Copy link
Member

Top 10 versions (including both pip and setuptools) used to install cryptography 2.2.2 (latest version) since it was released:

image

I'm baffled why 1.5.4 is so enormous. It isn't on any other PyCA project.

@dstufft
Copy link
Member

dstufft commented Apr 10, 2018

@alex alex changed the title [DO NOT MERGE] Fixes #3548 - add a pyproject.toml Fixes #3548 - add a pyproject.toml Apr 14, 2018
@alex alex changed the title Fixes #3548 - add a pyproject.toml [DO NOT MERGE] Fixes #3548 - add a pyproject.toml Apr 15, 2018
@alex
Copy link
Member Author

alex commented Apr 15, 2018

Turns out pip x only supports pyproject.toml with packages distributed as wheels, so we can't use it yet:

pypa/pip#5229

@alex
Copy link
Member Author

alex commented Jul 22, 2018

Closing in favor of #4363

@alex alex closed this Jul 22, 2018
@alex alex deleted the alex-patch-4 branch July 22, 2018 13:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants