Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Essential Hub IMU orientation not consistent with docs #848

Closed
laurensvalk opened this issue Dec 9, 2022 · 5 comments
Closed

[Bug] Essential Hub IMU orientation not consistent with docs #848

laurensvalk opened this issue Dec 9, 2022 · 5 comments
Labels
bug Something isn't working platform: essentialhub Issues related to the LEGO SPIKE Essential hub

Comments

@laurensvalk
Copy link
Member

No description provided.

@laurensvalk laurensvalk added bug Something isn't working platform: essentialhub Issues related to the LEGO SPIKE Essential hub labels Dec 9, 2022
@laurensvalk
Copy link
Member Author

laurensvalk commented Dec 9, 2022 •
edited
Loading

The docs currently say:

image

But that't not what's implemented for Essential Hub if you run on the REPL:

hub.imu.up()

@laurensvalk
Copy link
Member Author

laurensvalk commented Dec 9, 2022 •
edited
Loading

Unless anyone objects, I think the version in the docs makes sense. This way Prime Hub and Essential Hub both have:

  • USB towards front
  • light towards back

So the actionable item is to implement it that way.

@laurensvalk
Copy link
Member Author

laurensvalk commented Dec 9, 2022 •
edited
Loading

If we want to be really consistent with that (light towards the back) then the Technic needs to be flipped too:

image

Technically that is not a breaking change because IMUs were not officially part of V3.1. But people might be using it anyway.

@laurensvalk laurensvalk changed the title [Bug] Essential Hub IMU orientation not consistent with Prime Hub [Bug] Essential Hub IMU orientation not consistent with docs Dec 9, 2022
@laurensvalk
Copy link
Member Author

laurensvalk commented Dec 9, 2022 •
edited
Loading

I found another hint that keeps the Essential/Prime/Essential and even Technic and move hub consistent, assuming we make all of the aforementioned changes. If you can read the word LEGO normally then it all checks out! This is easy enough to remember too. The ABCD ports are then all the same between Technic/Prime/Inventor too, so this is probably how it is supposed to be.

laurensvalk added a commit to pybricks/pybricks-micropython that referenced this issue Dec 9, 2022
@laurensvalk
drv/imu_lsm6: Make orientation configurable.
af76eec 
Also add a specific definition in the comments.

See: pybricks/support#848.
laurensvalk added a commit to pybricks/pybricks-api that referenced this issue Dec 9, 2022
@laurensvalk
pybricks.parameters.Side: Change Technic Hub orientation.
585b1b8 
This makes it consistent with other hubs.

See: pybricks/support#848

The IMU section was not included in V3.1 so it is not a breaking change,
but we add a versionchanged comment just in case.
@laurensvalk
Copy link
Member Author

Fixed by the commits linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working platform: essentialhub Issues related to the LEGO SPIKE Essential hub
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laurensvalk