Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pybricks Code does not validate checksum during download #433

Closed
dlech opened this issue Aug 12, 2021 · 2 comments
Closed

Pybricks Code does not validate checksum during download #433

dlech opened this issue Aug 12, 2021 · 2 comments
Assignees
@dlech
Labels
enhancement New feature or request software: pybricks-code Issues with https://code.pybricks.com application topic: flashing firmware Issues related to fhe firmware flashing process

Comments

@dlech
Copy link
Member

dlech commented Aug 12, 2021

It also seems odd that we aren't getting an error from a bad checksum since the hub is not receiving all of the data. So there could be a bug there too.

Originally posted by @dlech in #403 (comment)
@dlech dlech added enhancement New feature or request software: pybricks-code Issues with https://code.pybricks.com application topic: flashing firmware Issues related to fhe firmware flashing process labels Aug 12, 2021
@dlech
Copy link
Member Author

dlech commented Aug 12, 2021

It looks like we aren't currently validating the checksum while flashing firmware in Pybricks Code. Instead, we only validate it at the very end. If we validate it as we go, then we can fail early if a packet is dropped and it would have helped identify the cause of #403.

dlech added a commit to pybricks/pybricks-code that referenced this issue Aug 13, 2021
@dlech
firmware: validate checksum while flashing
7ddeed5 
Since we are using the checksum message for throttling flash speed
anyway, we can validate the checksum during the flash process to
catch errors earlier.

Issue: pybricks/support#433
@dlech dlech self-assigned this Aug 13, 2021
@dlech
Copy link
Member Author

dlech commented Aug 13, 2021

Fix is released in Pybricks Beta v1.1.0-beta.4.

@dlech dlech closed this as completed Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlech dlech

Labels
enhancement New feature or request software: pybricks-code Issues with https://code.pybricks.com application topic: flashing firmware Issues related to fhe firmware flashing process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dlech