Update IMU API #137
Merged
Update IMU API #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update implementation status for heading and reset_heading.
|
It occurred to me that the threshold setter should probably be replaced by a settings method like we have everywhere else. That way we don’t need more methods when we add settings like the fusion feedback gain. Updated PR: Implementation has also been updated to match. |
This reverts commit dadaab6. We will introduce a separate class instead.
This is not a breaking change because heading() was never implemented until now.
This reverts commit e4650cb. This is not needed for gyro support, so it is better to remove it before it is ever released.
This will still work, but it is asking for trouble when including the gyro. So it is probably better not to mention this at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the methods below. This is implemented in
pybricks-micropythonunless stated otherwise.This should cover most of the intended use cases. The main thing that is missing are examples and intuitive explanations for the use of vectors and reference frames.
This would be good to include in the next beta release, so we have fairly usable IMU with matching docs.