-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BPX support #246
Add BPX support #246
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #246 +/- ##
===========================================
+ Coverage 95.35% 95.42% +0.07%
===========================================
Files 36 36
Lines 1979 1990 +11
===========================================
+ Hits 1887 1899 +12
+ Misses 92 91 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition @NicolaCourtier, on a whole this looks great! I've made two small comments that are worth investigating before merging. Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @NicolaCourtier.
LGTM, just one suggestion on the unit tests.
Description
Add support for importing BPX JSON files as parameter sets.
Issue reference
Adds feature request #79.
Type of change