Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to #177 #198

Merged
merged 26 commits into from
Mar 19, 2024

Fix integration test logic, add gradient landscape plots, pin pytest …

67d2887
Select commit
Loading
Failed to load commit list.
Merged

Additions to #177 #198

Fix integration test logic, add gradient landscape plots, pin pytest …
67d2887
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 4, 2024 in 0s

92.70% (-1.23%) compared to ed2bf7c

View this Pull Request on Codecov

92.70% (-1.23%) compared to ed2bf7c

Details

Codecov Report

Attention: Patch coverage is 78.04878% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 92.70%. Comparing base (ed2bf7c) to head (67d2887).

❗ Current head 67d2887 differs from pull request most recent head b6a073b. Consider uploading reports for the commit b6a073b to get more accurate results

Files Patch % Lines
pybop/plotting/plot_cost2d.py 12.00% 22 Missing ⚠️
pybop/costs/fitting_costs.py 88.00% 6 Missing ⚠️
pybop/observers/observer.py 90.00% 3 Missing ⚠️
pybop/models/lithium_ion/echem_base.py 50.00% 2 Missing ⚠️
pybop/costs/design_costs.py 87.50% 1 Missing ⚠️
pybop/models/base_model.py 87.50% 1 Missing ⚠️
pybop/plotting/plot_problem.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           177b-plotting-capabilities     #224      +/-   ##
==============================================================
- Coverage                       93.92%   92.70%   -1.23%     
==============================================================
  Files                              35       35              
  Lines                            1762     1836      +74     
==============================================================
+ Hits                             1655     1702      +47     
- Misses                            107      134      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.