-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check icon #277
Check icon #277
Conversation
That is an interesting idea! Could we maybe remove the box around the exclamation icon? |
Not sure if it's better - I think it's more clutter. How about after processing that the checkboxes turn "fully colored" instead of showing an icon - they would just be red, orange or green. And can't be toggled. |
+1 |
Here are the solid colors in action: Its in a PR for @mottosso fork; mottosso#3 |
Oh wow, that looks great. Merging that. |
Solid colored checkboxes on success, warning and error.
I have another PR which just cleans the added code and versions up, ready for a merge; mottosso#4 |
Check icon
Thanks @tokejepsen, happy to merge this. Any last comments? |
I'm good for a merge :) @BigRoy ? |
Looks awesome visually. Great work. |
Along the theme of section colors, I wanted to see what it'd look like to update the checkbox icon with something other than the check, as check normally means "all good", which isn't the case when things error.
Not sure it's an improvement.. Welcome to tinker.
As I was writing this, I discovered a minor bug in the previously merged PR; namely that the section icon went too dark when unexpanded and had no status.