Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check icon #277

Merged
merged 7 commits into from
Dec 18, 2017
Merged

Check icon #277

merged 7 commits into from
Dec 18, 2017

Conversation

mottosso
Copy link
Member

Along the theme of section colors, I wanted to see what it'd look like to update the checkbox icon with something other than the check, as check normally means "all good", which isn't the case when things error.

untitled project

Not sure it's an improvement.. Welcome to tinker.

As I was writing this, I discovered a minor bug in the previously merged PR; namely that the section icon went too dark when unexpanded and had no status.

untitled project

@tokejepsen
Copy link
Member

That is an interesting idea!

Could we maybe remove the box around the exclamation icon?
And how about the deprecation icon for warnings?

@BigRoy
Copy link
Member

BigRoy commented Dec 14, 2017

Not sure if it's better - I think it's more clutter.

How about after processing that the checkboxes turn "fully colored" instead of showing an icon - they would just be red, orange or green. And can't be toggled.

@tokejepsen
Copy link
Member

How about after processing that the checkboxes turn "fully colored" instead of showing an icon

+1

@tokejepsen
Copy link
Member

Here are the solid colors in action:

dec 18 2017 11_09 am

Its in a PR for @mottosso fork; mottosso#3

@mottosso
Copy link
Member Author

Oh wow, that looks great. Merging that.

mottosso and others added 3 commits December 18, 2017 10:19
@tokejepsen
Copy link
Member

I have another PR which just cleans the added code and versions up, ready for a merge; mottosso#4

@mottosso
Copy link
Member Author

Thanks @tokejepsen, happy to merge this. Any last comments?

@tokejepsen
Copy link
Member

I'm good for a merge :) @BigRoy ?

@BigRoy
Copy link
Member

BigRoy commented Dec 18, 2017

Looks awesome visually. Great work.

@mottosso mottosso merged commit 1a35024 into pyblish:master Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants