Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist status text until next event. #273

Merged
merged 2 commits into from
Dec 8, 2017
Merged

Conversation

tokejepsen
Copy link
Member

dec 6 2017 3_12 pm

@tokejepsen tokejepsen requested a review from mottosso December 6, 2017 14:25
@BigRoy
Copy link
Member

BigRoy commented Dec 6, 2017

Yes, this looks good. This has been requested by artists here too.


Now looking at the messages they might be confusing.

When clicking validate, it says: publishing.. - should this read validating..?
When clicking publish, it says: publishing.. - perfect!

When clicking validation and it finishes it says: Finished..
When clicking publish and it finished it says; Finished..
The end is ambiguous. Both might be confusing as to what could've happened.
Should those respectively read ``Finished validation..andFinished publish..` - or does that alter to much logic?

@tokejepsen
Copy link
Member Author

Now looking at the messages they might be confusing.

I agree. Currently though this would require quite a bit more development. Might be better left for a separate issue/PR.

Adding to this, it might be nice to have the status display the stages its going through; collecting... > Finished collection. > validating... > extracting... > integrating... > Finished.

@BigRoy
Copy link
Member

BigRoy commented Dec 6, 2017

Yes, separate issue sounds good.

@tokejepsen
Copy link
Member Author

Done :) #274

@tokejepsen tokejepsen mentioned this pull request Dec 8, 2017
@mottosso
Copy link
Member

mottosso commented Dec 8, 2017

I'm happy to merge this, can work out details after the fact. Fire at will!

@BigRoy
Copy link
Member

BigRoy commented Dec 8, 2017

Let's do this!

@tokejepsen tokejepsen merged commit 011fb0f into pyblish:master Dec 8, 2017
@BigRoy BigRoy mentioned this pull request Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants