Modal mode #269
Merged
Modal mode #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mottosso
reviewed
Nov 14, 2017
pyblish_qml/__init__.py
Outdated
| @@ -5,9 +5,9 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| def show(parent=None, targets=[]): | |||
| def show(parent=None, targets=[], modal=None): | |||
There was a problem hiding this comment.
Iiiih while you're at it, could you remove the [] in targets?
Pass None and convert it to a list within function instead. Lists in signature arguments are mutable, which means if you modify the list, the next call the the function (without targets=) will behave differently. Very difficult to debug!
|
This looks good. Just that one nitpick, and then please version up and release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a modal mode and a way to switch between modal and non-modal.
The motivation for a modal mode is because of threading issues in Nuke reported in #264.
Usage
Non-modal is the default when using
pyblish_qml.show().To invoke modal mode you can either explicitly call
pyblish_qml.show(modal=True)or set the environment variableos.environ["PYBLISH_QML_MODAL"] = "True".