Skip to content

Commit

Permalink
Make PYBIND11_INTERNALS_VERSION 6 the default on all platforms.
Browse files Browse the repository at this point in the history
  • Loading branch information
rwgk committed Feb 3, 2025
1 parent 8862cd4 commit 92afb88
Showing 1 changed file with 3 additions and 11 deletions.
14 changes: 3 additions & 11 deletions include/pybind11/detail/internals.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,22 +37,14 @@
/// further ABI-incompatible changes may be made before the ABI is officially
/// changed to the new version.
#ifndef PYBIND11_INTERNALS_VERSION
# if PY_VERSION_HEX >= 0x030C0000 || defined(_MSC_VER)
// Version bump for Python 3.12+, before first 3.12 beta release.
// Version bump for MSVC piggy-backed on PR #4779. See comments there.
# ifdef Py_GIL_DISABLED
# define PYBIND11_INTERNALS_VERSION 6
# else
# define PYBIND11_INTERNALS_VERSION 5
# endif
# else
# define PYBIND11_INTERNALS_VERSION 4
# endif
# define PYBIND11_INTERNALS_VERSION 6
#endif

// This requirement is mainly to reduce the support burden (see PR #4570).
static_assert(PY_VERSION_HEX < 0x030C0000 || PYBIND11_INTERNALS_VERSION >= 5,
"pybind11 ABI version 5 is the minimum for Python 3.12+");
static_assert(PYBIND11_INTERNALS_VERSION >= 4,
"pybind11 ABI version 4 is the minimum for all platforms.");

PYBIND11_NAMESPACE_BEGIN(PYBIND11_NAMESPACE)

Expand Down

0 comments on commit 92afb88

Please sign in to comment.