add virtual destructors (#25)

Co-authored-by: Martin Robinson <[email protected]>
pybamm-team · Jan 27, 2025 · 978eb32 · 978eb32
1 parent 727c032
commit 978eb32
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/pybammsolvers/idaklu_source/IDAKLUSolver.hpp b/src/pybammsolvers/idaklu_source/IDAKLUSolver.hpp
@@ -22,7 +22,7 @@ class IDAKLUSolver
   /**
    * @brief Default destructor
    */
-  ~IDAKLUSolver() = default;
+  virtual ~IDAKLUSolver() = default;
 
   /**
    * @brief Abstract solver method that executes the solver

diff --git a/src/pybammsolvers/idaklu_source/IDAKLUSolverOpenMP.hpp b/src/pybammsolvers/idaklu_source/IDAKLUSolverOpenMP.hpp
@@ -106,7 +106,7 @@ class IDAKLUSolverOpenMP : public IDAKLUSolver
   /**
    * @brief Destructor
    */
-  ~IDAKLUSolverOpenMP();
+  virtual ~IDAKLUSolverOpenMP();
 
   /**
    * @brief The main solve method that solves for each variable and time step