-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the failing CI and docs #161
Conversation
Can we now not do
|
Hi @Saransh-cpp thanks for raising this PR. I think the problem is that the variables got slightly redefined. I have another PR that fixes this issue using |
@Saransh-cpp my ci build on github seems to be working but if I login to readthedocs and manually build the branch I get an error. Seems like ray is re-installing the latest protobuf |
Yes, makes sense! I'll close this one up For the RTD error, I found this in the logs -
RTD is running |
The CI is failing with an error -
The error originates from a breaking change in the new
protobuf
release which is used byray
.Ray
has fixed this on the development branch but hasn't tagged a new version yet, see' - ray-project/ray#25282.The docs are failing with a weird issue related to
site.py
(here is a thread on this - pypa/virtualenv#737) -The docs are using
PyBaMM
version22.4
, which might be an issue? If not then the virtual environment would have to be checked.This PR also changes the old parameter style to the new refactored one!