Issue 757 rate capability #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…brosa/PyBaMM into issue-757-rate-capability
valentinsulzer
approved these changes
Feb 20, 2020
examples/scripts/DFN_high_Crate.py
Outdated
| disc.process_model(model) | ||
|
|
||
| # solve model | ||
| t_eval = np.linspace(0, 0.2, 1E4) |
There was a problem hiding this comment.
needs to be updated with t_eval in seconds
There was a problem hiding this comment.
I did this such a long time ago that I thought someone else had done it haha. I have removed it now.
| plt.scatter(currents * voltage_av, capacities * voltage_av) | ||
| plt.xlabel('Power [W]') | ||
| plt.ylabel('Energy [Wh]') | ||
|
|
.gitignore
Outdated
| @@ -91,3 +91,6 @@ cmake_install.cmake | |||
|
|
|||
|
|
|||
| third-party/pybind11 | |||
|
|
|||
| # LGM50 results | |||
| results/LGM50/ | |||
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
==========================================
+ Coverage 98.19% 98.24% +0.05%
==========================================
Files 181 180 -1
Lines 10227 10277 +50
==========================================
+ Hits 10042 10097 +55
+ Misses 185 180 -5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added an example script that generates rate capability plots. The implementation is not the best, so feedback on how to make it more efficient is welcome. In any case, I think it is a good first step to include in v0.2.
Because it is an example, rather than a new feature, I haven't added to CHANGELOG.md.
Fixes #757
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: