-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 746 broadcasting #747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great thanks @tinosulzer ! much more user friendly now (once tests are fixed!)
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
==========================================
+ Coverage 98.35% 98.36% +<.01%
==========================================
Files 175 175
Lines 9599 9880 +281
==========================================
+ Hits 9441 9718 +277
- Misses 158 162 +4
Continue to review full report at Codecov.
|
Description
Remove outers and primary broadcasts from some models and do it automatically instead.
Fixes #746
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: