Creates a 'calc_esoh' property in the BaseModel #4825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… override False in BaseModel, True in lithium_ion.BaseModel
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4825 +/- ##
========================================
Coverage 98.70% 98.70%
========================================
Files 303 303
Lines 23314 23334 +20
========================================
+ Hits 23011 23031 +20
Misses 303 303 ☔ View full report in Codecov by Sentry. |
pipliggins
requested review from
a team,
brosaplanella,
DrSOKane,
rtimms,
valentinsulzer and
TomTranter
as code owners
kratman
reviewed
Feb 11, 2025
src/pybamm/models/full_battery_models/lithium_ion/base_lithium_ion_model.py
Outdated
Show resolved
Hide resolved
src/pybamm/models/full_battery_models/lithium_ion/base_lithium_ion_model.py
Outdated
Show resolved
Hide resolved
Make docstrings triple quotes Co-authored-by: Eric G. Kratz <[email protected]>
kratman
approved these changes
Feb 11, 2025
RohitP2005
pushed a commit
to RohitP2005/PyBaMM
that referenced
this pull request
Feb 13, 2025
* Creates a 'calc_esoh' property in the BaseModel, allows Simulation to override False in BaseModel, True in lithium_ion.BaseModel * Fix style issue * Update changelog * Add setter for calc_esoh attr in lithium BaseModel * Apply suggestions from code review Make docstrings triple quotes Co-authored-by: Eric G. Kratz <[email protected]> --------- Co-authored-by: Eric G. Kratz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a 'cal_esoh' property in the model class, set to False for the BaseModel, and True for the lithium ion BaseModel.
Allows the logic for whether eSOH variables should be calculated to be stored in the model, while allowing
Simulation.solve()to override the model setting (i.e. set calc_esoh to False) as is the current behaviour.Fixes #4619