Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for particle size distributions combined with particle mechanics. #4807

Merged
merged 9 commits into from
Feb 3, 2025

Conversation

aabills
Copy link
Contributor

@aabills aabills commented Jan 28, 2025

self-descriptive.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (c017be4) to head (adc092a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4807   +/-   ##
========================================
  Coverage    98.69%   98.70%           
========================================
  Files          303      303           
  Lines        23258    23312   +54     
========================================
+ Hits         22955    23009   +54     
  Misses         303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aabills aabills marked this pull request as ready for review January 28, 2025 23:18
@aabills
Copy link
Contributor Author

aabills commented Jan 28, 2025

test failure unrelated

@aabills aabills requested a review from kratman January 31, 2025 19:34
@rtimms rtimms merged commit 04422b1 into pybamm-team:develop Feb 3, 2025
26 checks passed
medha-14 pushed a commit to medha-14/PyBaMM that referenced this pull request Feb 3, 2025
…echanics. (pybamm-team#4807)

* add particle stress distribution variables

* add cracking

* add test

* fix tests and mpm issue

* coverage

* changelog

* changelog format

* eric comment

* fix test failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants