Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ec reaction bug #4774

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Conversation

aabills
Copy link
Contributor

@aabills aabills commented Jan 17, 2025

Description

#4394 introduced a bug in ec-reaction limited sei, this reverts the problematic change

@kratman lets do a patch release
@kawaMANMI can you take a look at this and make sure it doesn't break your code. also please try and be careful with stuff like this

Fixes #4773

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@aabills aabills requested a review from a team as a code owner January 17, 2025 18:39
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (c9cb2bb) to head (1dd2fcb).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4774      +/-   ##
===========================================
+ Coverage    98.66%   98.69%   +0.03%     
===========================================
  Files          303      303              
  Lines        23227    23226       -1     
===========================================
+ Hits         22916    22923       +7     
+ Misses         311      303       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aabills aabills merged commit ef8571c into pybamm-team:develop Jan 17, 2025
26 checks passed
@Brushnie
Copy link

there is a typo in the change-log, "ec-reaction" not "wc-reaction"
image

@kratman
Copy link
Contributor

kratman commented Jan 21, 2025

@Brushnie I saw it when I made the release. I have a PR up for it

@kratman kratman deleted the fix-ec-reaction-sei-bug branch January 21, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ec reaction sei growth model seems so different in 25.1 from previous versions
3 participants