Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license copyright year(s) #4727

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 1, 2025

No description provided.

@arjxn-py arjxn-py enabled auto-merge (squash) January 1, 2025 07:48
@agriyakhetarpal
Copy link
Member

I think auto-merge won't work because we need CI to run because of required checks (which, again, sounds wasteful to me and to the environment in the way they have been configured right now)

@arjxn-py
Copy link
Member

arjxn-py commented Jan 1, 2025

I think auto-merge won't work because we need CI to run because of required checks (which, again, sounds wasteful to me and to the environment in the way they have been configured right now)

i see, then i'll come back to it once CI is happy

@arjxn-py arjxn-py disabled auto-merge January 1, 2025 08:12
@arjxn-py arjxn-py enabled auto-merge (squash) January 1, 2025 09:20
@arjxn-py arjxn-py disabled auto-merge January 1, 2025 09:20
@kratman kratman enabled auto-merge (squash) January 2, 2025 14:50
@kratman kratman merged commit c64b48a into develop Jan 2, 2025
24 checks passed
@kratman kratman deleted the license/copyright-to-2025 branch January 2, 2025 14:56
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.22%. Comparing base (a7253b8) to head (cef4318).
Report is 16 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4727      +/-   ##
===========================================
- Coverage    99.22%   99.22%   -0.01%     
===========================================
  Files          303      303              
  Lines        23070    23101      +31     
===========================================
+ Hits         22891    22921      +30     
- Misses         179      180       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agriyakhetarpal
Copy link
Member

FYI, while we've done this now, the consensus apparently is that it is no longer needed to continue to update the copyright years for the recipe. Here are some references:

So, it should be fine to drop this workflow altogether – it's all the more better for our CI if we keep our workflows maintainable and drop unneeded workflows.

@arjxn-py arjxn-py mentioned this pull request Jan 15, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants