Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tertiary integral to FV method #4710

Merged
merged 7 commits into from
Jan 3, 2025
Merged

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Dec 23, 2024

Description

Adds tertiary integral to the Finite Volume method

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@rtimms
Copy link
Contributor Author

rtimms commented Dec 23, 2024

@aabills

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.25%. Comparing base (a7253b8) to head (0042138).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4710      +/-   ##
===========================================
+ Coverage    99.22%   99.25%   +0.02%     
===========================================
  Files          303      303              
  Lines        23070    23230     +160     
===========================================
+ Hits         22891    23056     +165     
+ Misses         179      174       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aabills aabills added the release blocker Issues that need to be addressed before the creation of a release label Dec 23, 2024
@aabills
Copy link
Contributor

aabills commented Dec 23, 2024

Thanks @rtimms. I can add a quick test to fix coverage if you want

@aabills
Copy link
Contributor

aabills commented Dec 30, 2024

Thanks @rtimms. I can add a quick test to fix coverage if you want

Turns out it's not possible to reach the uncovered line, so deleted it.

@rtimms rtimms enabled auto-merge (squash) December 30, 2024 21:16
@aabills
Copy link
Contributor

aabills commented Jan 2, 2025

@rtimms can we merge #4665 before this, there will be a conflict that will be easier to resolve here.

@rtimms
Copy link
Contributor Author

rtimms commented Jan 2, 2025

@aabills sounds good

@rtimms rtimms disabled auto-merge January 2, 2025 17:10
@kratman kratman requested a review from aabills January 2, 2025 21:42
@aabills aabills merged commit bb28150 into develop Jan 3, 2025
26 checks passed
@aabills aabills deleted the add-tertiary-integral-FV branch January 3, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release blocker Issues that need to be addressed before the creation of a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants