Restore modulo coverage #4143
Merged
Restore modulo coverage #4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4143 +/- ##
===========================================
+ Coverage 99.55% 99.58% +0.02%
===========================================
Files 288 288
Lines 21790 21789 -1
===========================================
+ Hits 21693 21698 +5
+ Misses 97 91 -6 ☔ View full report in Codecov by Sentry. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
kratman
requested review from
arjxn-py,
agriyakhetarpal,
Saransh-cpp,
martinjrobins,
rtimms,
valentinsulzer and
TomTranter
as code owners
|
This should fix all the coverage lost in #3932 by re-adding one of the tests from ODEs to the Casadi test suite. The code is not 100% covered, but it was not before either. This does replace what was lost and does some minor cleanup. |
rtimms
approved these changes
Jun 7, 2024
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this pull request
Aug 12, 2024
* Starting to fix modulo coverage * Remove quotes from the if-statement * Adjust logic * Fix job naming * Change order * Cleanup * Re-adding test * A bit more refactoring * Fix a line of coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve coverage in the base solver that went down due to the removal of the ODEs solver.
Fixes #3941
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: