-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More simplifications #2424
More simplifications #2424
Conversation
Codecov ReportBase: 99.72% // Head: 99.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2424 +/- ##
===========================================
- Coverage 99.72% 99.72% -0.01%
===========================================
Files 258 258
Lines 19261 19184 -77
===========================================
- Hits 19208 19131 -77
Misses 53 53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks good!
The benchmarks are slower for setup but faster for solve |
Description
More simplifications of the expression tree. Whenever there is a binary operator with a constant, the constant is moved to the left. This makes it easier to find constants.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: