Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #2379

Conversation

agriyakhetarpal
Copy link
Member

Description

This change drops support for Python 3.7.

Fixes #2370

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 99.66% // Head: 99.66% // No change to project coverage 👍

Coverage data is based on head (222be25) compared to base (c89445e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2379   +/-   ##
========================================
  Coverage    99.66%   99.66%           
========================================
  Files          269      269           
  Lines        20206    20206           
========================================
  Hits         20139    20139           
  Misses          67       67           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valentinsulzer
Copy link
Member

Thanks @agriyakhetarpal !

@valentinsulzer
Copy link
Member

@all-contributors add @agriyakhetarpal for infrastructure

@valentinsulzer valentinsulzer merged commit 67a4c50 into pybamm-team:develop Oct 19, 2022
@valentinsulzer
Copy link
Member

valentinsulzer commented Oct 19, 2022

@all-contributors add @agriyakhetarpal for infra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop python 3.7 support
2 participants