-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1611 cccv #1612
Issue 1611 cccv #1612
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1612 +/- ##
========================================
Coverage 97.92% 97.93%
========================================
Files 324 324
Lines 18150 18216 +66
========================================
+ Hits 17773 17839 +66
Misses 377 377
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! Thanks, @tinosulzer!
if self.control == "algebraic": | ||
i_cell = i_var | ||
elif self.control == "differential": | ||
i_cell = pybamm.maximum(i_var, param.current_with_time) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be useful to add a comment or point to a reference saying why you get maximum
here
Description
Fixes #1611
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: