-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add empty inits to parameters subfolders #1555
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1555 +/- ##
===========================================
- Coverage 98.28% 97.78% -0.51%
===========================================
Files 310 323 +13
Lines 17402 17491 +89
===========================================
Hits 17103 17103
- Misses 299 388 +89
Continue to review full report at Codecov.
|
I guess we also need these for lead acid |
Yep looks like you do. Just tried running compare_extrapolations twice and it failed. This is confusing slightly as I would have thought it would just break on import pybamm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @TomTranter ! Yeah don't worry about coverage
Description
When running scripts through spyder on windows (at least this is what I tested) if you press run twice there is an importlib KeyError. The kernel had to be restarted to fix the issue. Adding empty __init__files to parameter subfolders fixes the issue
Fixes #1479
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: