Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1406 fixed bug with positive electrode ohmic losses #1407

Merged
merged 2 commits into from
Feb 28, 2021
Merged

#1406 fixed bug with positive electrode ohmic losses #1407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cc397b
#1406 fixed bug with positive electrode ohmic losses
brosaplanella Feb 27, 2021
a7043df
#1406 update CHANGELOG
brosaplanella Feb 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

## Bug fixes

- Fixed a sign error in the positive electrode ohmic losses ([#1407](https://github.com/pybamm-team/PyBaMM/pull/1407))
- Simulations now stop when an experiment becomes infeasible ([#1395](https://github.com/pybamm-team/PyBaMM/pull/1395))
- Added a check for domains in `Concatenation` ([#1368](https://github.com/pybamm-team/PyBaMM/pull/1368))
- Differentiation now works even when the differentiation variable is a constant ([#1294](https://github.com/pybamm-team/PyBaMM/pull/1294))
Expand Down
2 changes: 1 addition & 1 deletion pybamm/models/submodels/electrode/base_electrode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def _get_standard_potential_variables(self, phi_s):
phi_s_av_dim = param.U_p_ref - param.U_n_ref + pot * phi_s_av

v = pybamm.boundary_value(phi_s, "right")
delta_phi_s = phi_s - v
delta_phi_s = v - phi_s
delta_phi_s_av = pybamm.x_average(delta_phi_s)
delta_phi_s_dim = delta_phi_s * pot
delta_phi_s_av_dim = delta_phi_s_av * pot
Expand Down