Code

Issue 1195 track cycles in solution#1309

Code

Merged

valentinsulzer merged 19 commits intopybamm-team:developpybamm-team/PyBaMM:developfrom lonnbornj:issue-1195-track-cycles-in-solutionlonnbornj/PyBaMM:issue-1195-track-cycles-in-solutionCopy head branch name to clipboardDec 31, 2020

+112-36

Commits

Commits on Dec 20, 2020

• logic to parse cycles in definition of an Experiment

  lonnbornj

  committed
  42f595e

  Copy full SHA for 42f595e

• add list of cycles to Solution

  lonnbornj

  committed
  e6fa241

  Copy full SHA for e6fa241

Commits on Dec 27, 2020

• add test for cycle unpacking

  lonnbornj

  committed
  3f9888e

  Copy full SHA for 3f9888e

• add test for Solution.cycles

  lonnbornj

  committed
  2ddef1b

  Copy full SHA for 2ddef1b

• build cycles only if solution has subsolutions

  lonnbornj

  committed
  ddce12c

  Copy full SHA for ddce12c

• rename experiment.cycle_length to cycle_lengths

  lonnbornj

  committed
  d876831

  Copy full SHA for d876831

• Merge remote-tracking branch 'origin/develop' into issue-1195-track-cycles-in-solution

  lonnbornj

  committed
  eb589c5

  Copy full SHA for eb589c5

Commits on Dec 28, 2020

• made test slightly faster

  lonnbornj

  committed
  99583be

  Copy full SHA for 99583be

• ran black

  lonnbornj

  committed
  2036fa2

  Copy full SHA for 2036fa2

Commits on Dec 29, 2020

• fix type-checking for cycles and conditions within cycles

  lonnbornj

  committed
  5f96236

  Copy full SHA for 5f96236

• test mixed cycle length and mixed tuples/string, and bad cycle definition

  lonnbornj

  committed
  94e5f2f

  Copy full SHA for 94e5f2f

• refactored for readability

  lonnbornj

  committed
  bc97174

  Copy full SHA for bc97174

• explanatory comment

  lonnbornj

  committed
  801f2f4

  Copy full SHA for 801f2f4

Commits on Dec 30, 2020

• modified examples to use cycles

  lonnbornj

  committed
  eb9b9fd

  Copy full SHA for eb9b9fd

• updated changelog

  lonnbornj

  committed
  3fd783e

  Copy full SHA for 3fd783e

• black

  lonnbornj

  committed
  eb2cbea

  Copy full SHA for eb2cbea

• fixed bare except clause

  lonnbornj

  committed
  28b4731

  Copy full SHA for 28b4731

• append tuple instead of extending with a list of tuple

  lonnbornj

  committed
  3282bd9

  Copy full SHA for 3282bd9

Commits on Dec 31, 2020

• modified to show use of cycles

  lonnbornj

  committed
  692b19d

  Copy full SHA for 692b19d