Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slider bug fix #1043

Merged
merged 52 commits into from
Jun 9, 2020
Merged

slider bug fix #1043

merged 52 commits into from
Jun 9, 2020

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Jun 9, 2020

merge develop into master for release

@rtimms rtimms requested a review from tlestang June 9, 2020 13:03
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #1043 into master will increase coverage by 0.06%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1043      +/-   ##
==========================================
+ Coverage   97.56%   97.63%   +0.06%     
==========================================
  Files         232      237       +5     
  Lines       12119    12371     +252     
==========================================
+ Hits        11824    12078     +254     
+ Misses        295      293       -2     
Impacted Files Coverage Δ
...odels/full_battery_models/lithium_ion/basic_dfn.py 100.00% <ø> (ø)
...odels/full_battery_models/lithium_ion/basic_spm.py 100.00% <ø> (ø)
...bamm/models/full_battery_models/lithium_ion/dfn.py 100.00% <ø> (ø)
pybamm/parameters/parameter_sets.py 100.00% <ø> (ø)
pybamm/parameters_cli.py 0.00% <0.00%> (ø)
pybamm/spatial_methods/scikit_finite_element.py 98.24% <ø> (ø)
pybamm/spatial_methods/spatial_method.py 96.15% <ø> (+0.19%) ⬆️
pybamm/spatial_methods/zero_dimensional_method.py 100.00% <ø> (ø)
pybamm/expression_tree/concatenations.py 97.45% <90.90%> (-0.54%) ⬇️
pybamm/models/submodels/interface/sei/base_sei.py 97.82% <92.30%> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eff587b...d1a7e88. Read the comment docs.

@tlestang tlestang merged commit 66dc659 into master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants