Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reactions dictionary #933

Closed
valentinsulzer opened this issue Apr 2, 2020 · 0 comments · Fixed by #948
Closed

Remove reactions dictionary #933

valentinsulzer opened this issue Apr 2, 2020 · 0 comments · Fixed by #948
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

The reactions dictionary is probably a bit confusing and overly generalized, I suggest removing it and dealing with the different reactions individually in each submodel
@valentinsulzer valentinsulzer self-assigned this Apr 5, 2020
valentinsulzer added a commit that referenced this issue Apr 6, 2020
@valentinsulzer
#933 start removing reactions dict
66dd222
valentinsulzer added a commit that referenced this issue Apr 6, 2020
@valentinsulzer
#933 remove reactions dict
5957a80
valentinsulzer added a commit that referenced this issue Apr 6, 2020
@valentinsulzer
#933 fix tests
18e7fd4
@valentinsulzer valentinsulzer mentioned this issue Apr 7, 2020
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Apr 8, 2020
@valentinsulzer
#933 merge develop
d6a7f39
valentinsulzer added a commit that referenced this issue Apr 9, 2020
@valentinsulzer
#933 merge #546
23c6e2a
valentinsulzer added a commit that referenced this issue Apr 9, 2020
@valentinsulzer
#933 fix tests except public functions
4fdf3d8
valentinsulzer added a commit that referenced this issue Apr 24, 2020
@valentinsulzer
#933 debugging
e0fce7d
valentinsulzer added a commit that referenced this issue Apr 24, 2020
@valentinsulzer
#933 fix unit tests
0aea591
valentinsulzer added a commit that referenced this issue Apr 24, 2020
@valentinsulzer
#933 fixing tests
a338812
@valentinsulzer valentinsulzer mentioned this issue Apr 24, 2020
Closed
4 tasks
valentinsulzer added a commit that referenced this issue Apr 24, 2020
@valentinsulzer
#933 fix integration tests
9af70dd
valentinsulzer added a commit that referenced this issue Apr 24, 2020
@valentinsulzer
#933 fix weirdly broken test ...
68bdfd9
valentinsulzer added a commit that referenced this issue Apr 24, 2020
@valentinsulzer
834 merge #933
66dba05
@felipe-salinas felipe-salinas mentioned this issue Apr 27, 2020
Closed
valentinsulzer added a commit that referenced this issue Apr 29, 2020
@valentinsulzer
#933 merge
0eb8e14
valentinsulzer added a commit that referenced this issue Apr 29, 2020
@valentinsulzer
#933 fix test
8d1daa8
valentinsulzer added a commit that referenced this issue Apr 29, 2020
@valentinsulzer
#933 fix example
c270b12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 933 remove reactions dict pybamm-team/PyBaMM
1 participant
@valentinsulzer