Add "temperature" argument to experiment

[valentinsulzer]

Simulation should then update the parameter values ("Ambient temperature [K]" and "Initial temperature [K]", not "Reference temperature [K]"), with the given temperature

[Niiola]

can i get more explanation on this project and also i would love to be assigned this task

[valentinsulzer]

1. In the Experiment (https://github.com/pybamm-team/PyBaMM/blob/develop/pybamm/experiments/experiment.py) class, add a new attribute temperature which is None by default but can be provided
2. In the Simulation (https://github.com/pybamm-team/PyBaMM/blob/develop/pybamm/simulation.py) class __init__, if experiment.temperature is not None, update ambient and initial temperature in the parameter values with the given temperature.

[Scottmar93]

I also think temperature control is super useful to have in the experiment class.

@tinosulzer what's your view on the complexity of allowing the ambient temperature to be controllable on the step level? e.g.

   experiment = pybamm.Experiment(
    [
        (
            "Discharge at C/10 for 10 hours or until 3.3 V at 25oC",
            "Rest for 1 hour at 35oC",
            "Charge at 100 A until 4.1 V at 35oC (1 second period)",
            "Hold at 4.1 V until 5 A at 35oC (1 seconds period)",
            "Rest for 1 hour at 25oC",
        ),
    ]
)

This would give the experiment class a similar level of control as most battery cyclers.

[valentinsulzer]

This would be super easy, the hardest part would probably be reading the string to extract the temperature, e.g. adding a new field "T" for the operating conditions. Once that is done, it's just a matter of updating the parameter values for each step before processing the model here

[Scottmar93]

Nice! That is great to hear.

Is this something worth doing within this issue or separately? Can perhaps be done separately with this issue setting a global temperature and any temperature set on a step overwriting it.

[valentinsulzer]

I don't mind, whichever you prefer

[valentinsulzer]

Feel free to take over this issue too unless @Niiola has made progress?

[Scottmar93]

Happy to do as @Niiola wishes 😄

[Niiola]

You can go ahead

…

On Sun, Nov 20, 2022 at 5:04 PM Scott Marquis ***@***.***> wrote: Happy to do as @Niiola <https://github.com/Niiola> wishes 😄 — Reply to this email directly, view it on GitHub <#2358 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVQLHJKVJ6PRKIPOBCECS3LWJJDZLANCNFSM6AAAAAARDZO6BQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>