Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moar simplifications 'n' stuff #1429

Closed
valentinsulzer opened this issue Mar 12, 2021 · 0 comments · Fixed by #1449
Closed

Moar simplifications 'n' stuff #1429

valentinsulzer opened this issue Mar 12, 2021 · 0 comments · Fixed by #1449
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

valentinsulzer commented Mar 12, 2021 •
edited
Loading

Some more automatic simplifications of the expression tree

  • Commute neg/abs/function and broadcasts
  • -1 * x returns -x
  • Concatenation of Broadcasts that all have the same child returns Broadcast of the child across all concatenation domains
  • Concatenation commutes with elementwise operators
  • a few other minor ones
valentinsulzer added a commit that referenced this issue Mar 12, 2021
@valentinsulzer
#1429 commute broadcast operator and simplify -1*x
12a7590
valentinsulzer added a commit that referenced this issue Mar 12, 2021
@valentinsulzer
#1429 flake8
3146186
valentinsulzer added a commit that referenced this issue Mar 13, 2021
@valentinsulzer
#1429 debugging
7ff498f
valentinsulzer added a commit that referenced this issue Mar 13, 2021
@valentinsulzer
#1429 fixed some more tests
e761fdb
valentinsulzer added a commit that referenced this issue Mar 13, 2021
@valentinsulzer
#1429 flake8
7a580fe
valentinsulzer added a commit that referenced this issue Mar 13, 2021
@valentinsulzer
#1429 some more bug fixes
a8d7e04
valentinsulzer added a commit that referenced this issue Mar 14, 2021
@valentinsulzer
#1429 fixing more tests
8983ccb
valentinsulzer added a commit that referenced this issue Mar 14, 2021
@valentinsulzer
#1429 speed up hashing
9aad14a
valentinsulzer added a commit that referenced this issue Mar 14, 2021
@valentinsulzer
#1429 more hacky test fixes
397736c
valentinsulzer added a commit that referenced this issue Mar 14, 2021
@valentinsulzer
#1429 try new is_matrix_x implementation
1a4a487
valentinsulzer added a commit that referenced this issue Mar 14, 2021
@valentinsulzer
#1429 a few more simplifications
4a0b73d
valentinsulzer added a commit that referenced this issue Mar 17, 2021
@valentinsulzer
#1429 fix some tests
e4e9d40
valentinsulzer added a commit that referenced this issue Mar 17, 2021
@valentinsulzer
#1429 more test fixes
e32c6d0
valentinsulzer added a commit that referenced this issue Mar 18, 2021
@valentinsulzer
#1429 try test fix
1da9f11
valentinsulzer added a commit that referenced this issue Mar 18, 2021
@valentinsulzer
#1429 concatenation simplifications
e29986b
valentinsulzer added a commit that referenced this issue Mar 18, 2021
@valentinsulzer
#1429 another test fix
b7c0e1f
valentinsulzer added a commit that referenced this issue Mar 26, 2021
@valentinsulzer
#1429 merge develop
b9d79d6
valentinsulzer added a commit that referenced this issue Mar 26, 2021
@valentinsulzer
#1429 more concatenation simplifications
46f73db
valentinsulzer added a commit that referenced this issue Mar 26, 2021
@valentinsulzer
#1429 fix tests
a52c7e2
valentinsulzer added a commit that referenced this issue Mar 27, 2021
@valentinsulzer
#1429 recursive broadcast check
c6eadba
@valentinsulzer valentinsulzer mentioned this issue Mar 27, 2021
Merged
8 tasks
@valentinsulzer valentinsulzer self-assigned this Mar 27, 2021
valentinsulzer added a commit that referenced this issue Mar 27, 2021
@valentinsulzer
#1429 fix recursion error
2a7ed06
valentinsulzer added a commit that referenced this issue Mar 27, 2021
@valentinsulzer
#1429 fix example
f0a4ddc
valentinsulzer added a commit that referenced this issue Mar 27, 2021
@valentinsulzer
#1429 changelog
9171cfb
valentinsulzer added a commit that referenced this issue Mar 27, 2021
@valentinsulzer
#1429 codacy and coverage
5f03bf5
valentinsulzer added a commit that referenced this issue Mar 27, 2021
@valentinsulzer
#1429 coverage
458f77a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1429 simplifications pybamm-team/PyBaMM
1 participant
@valentinsulzer