Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make thermodynamic factor and transference number temperature dependent #1063

Closed
brosaplanella opened this issue Jun 19, 2020 · 1 comment · Fixed by #1317
Closed

Make thermodynamic factor and transference number temperature dependent #1063

brosaplanella opened this issue Jun 19, 2020 · 1 comment · Fixed by #1317
Assignees
@brosaplanella

Comments

@brosaplanella
Copy link
Member

Summary
Include temperature dependence on the thermodynamic factor (1 + d ln f/d ln c) and the transference number.

Motivation
Given that the other electrolyte parameters can depend on temperature, it would be nice that TDF and transference number do too for consistency.
@brosaplanella
Copy link
Member Author

The thermodynamic factor already depends on temperature (#1232) so only the transference number left.

@brosaplanella brosaplanella self-assigned this Jan 2, 2021
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jan 2, 2021
@brosaplanella
pybamm-team#1063 add temperature dependence to t_plus
8dc2e50
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jan 2, 2021
@brosaplanella
pybamm-team#1063 remove default T value from Landesfeind
bd1dc12
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jan 2, 2021
@brosaplanella
pybamm-team#1063 fix tests
27a9c7e
@brosaplanella brosaplanella mentioned this issue Jan 2, 2021
Merged
8 tasks
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jan 3, 2021
@brosaplanella
pybamm-team#1063 update CHANGELOG
8678cb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brosaplanella brosaplanella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1063 tplus temperature dependent brosaplanella/PyBaMM
1 participant
@brosaplanella