Skip to content

Commit

Permalink
feat: add scikit-build-core editable install support for Docker
Browse files Browse the repository at this point in the history
  • Loading branch information
cringeyburger committed Aug 17, 2024
1 parent 82147bc commit e046696
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
context: .
file: scripts/Dockerfile
tags: pybamm/pybamm:latest
push: true
push: false
platforms: linux/amd64, linux/arm64

- name: List built image(s)
Expand Down
12 changes: 6 additions & 6 deletions scripts/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ USER pybamm

WORKDIR /home/pybamm/

RUN git clone https://github.com/pybamm-team/PyBaMM.git
# TODO: Change clone to upstream before PR merge
RUN git clone --branch migrate-to-sbc https://github.com/cringeyburger/PyBaMM.git

WORKDIR /home/pybamm/PyBaMM

Expand All @@ -28,11 +29,10 @@ RUN uv venv $VIRTUAL_ENV
RUN #!/bin/bash && source /home/pybamm/venv/bin/activate;
ENV PATH="$VIRTUAL_ENV/bin:$PATH"

RUN uv pip install --upgrade setuptools wheel wget cmake

RUN uv pip install --upgrade scikit-build-core==0.10.3 wget cmake casadi pybind11
ENV BUILD_IDAKLU=ON
RUN python scripts/install_KLU_Sundials.py && \
rm -rf pybind11 && \
git clone https://github.com/pybind/pybind11.git && \
uv pip install -e ".[all,dev,docs,jax]";
uv pip install --no-build-isolation --config-settings=editable.rebuild=true -Cbuild-dir=build -ve ".[all,dev,docs,jax]";


ENTRYPOINT ["/bin/bash"]

0 comments on commit e046696

Please sign in to comment.