#1477 swap to using current function for sens tests

pybamm-team · Aug 18, 2021 · df0ff95 · df0ff95
1 parent 1daa4ba
commit df0ff95
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 11 deletions.
diff --git a/tests/integration/test_models/standard_model_tests.py b/tests/integration/test_models/standard_model_tests.py
@@ -94,6 +94,15 @@ def test_outputs(self):
 
     def test_sensitivities(self, param_name, param_value,
                            output_name='Terminal voltage [V]'):
+
+        self.parameter_values.update({param_name: param_value})
+        Crate = abs(
+            self.parameter_values["Current function [A]"]
+            / self.parameter_values["Nominal cell capacity [A.h]"]
+        )
+        t_eval = np.linspace(0, 3600 / Crate, 100)
+
+        # make param_name an input
         self.parameter_values.update({param_name: "[input]"})
         inputs = {param_name: param_value}
 
@@ -104,12 +113,6 @@ def test_sensitivities(self, param_name, param_value,
         self.solver.rtol = 1e-8
         self.solver.atol = 1e-8
 
-        Crate = abs(
-            self.parameter_values["Current function [A]"]
-            / self.parameter_values["Nominal cell capacity [A.h]"]
-        )
-        t_eval = np.linspace(0, 3600 / Crate, 100)
-
         self.solution = self.solver.solve(
             self.model, t_eval, inputs=inputs,
             calculate_sensitivities=True

diff --git a/tests/integration/test_models/test_full_battery_models/test_lithium_ion/test_dfn.py b/tests/integration/test_models/test_full_battery_models/test_lithium_ion/test_dfn.py
@@ -32,8 +32,7 @@ def test_sensitivities(self):
             model, parameter_values=param, var_pts=var_pts
         )
         modeltest.test_sensitivities(
-            #'Separator thickness [m]', 2e-05,
-            'Typical current [A]', 0.15652,
+            'Current function [A]', 0.15652,
         )
 
     def test_basic_processing_1plus1D(self):

diff --git a/tests/integration/test_models/test_full_battery_models/test_lithium_ion/test_spm.py b/tests/integration/test_models/test_full_battery_models/test_lithium_ion/test_spm.py
@@ -23,7 +23,7 @@ def test_sensitivities(self):
         param = pybamm.ParameterValues(chemistry=pybamm.parameter_sets.Ecker2015)
         modeltest = tests.StandardModelTest(model, parameter_values=param)
         modeltest.test_sensitivities(
-            'Typical current [A]', 0.15652,
+            'Current function [A]', 0.15652,
         )
 
     def test_basic_processing_1plus1D(self):

diff --git a/tests/integration/test_models/test_full_battery_models/test_lithium_ion/test_spme.py b/tests/integration/test_models/test_full_battery_models/test_lithium_ion/test_spme.py
@@ -25,8 +25,7 @@ def test_sensitivities(self):
         param = pybamm.ParameterValues(chemistry=pybamm.parameter_sets.Ecker2015)
         modeltest = tests.StandardModelTest(model, parameter_values=param)
         modeltest.test_sensitivities(
-            #'Separator thickness [m]', 2e-05,
-            'Typical current [A]', 0.15652,
+            'Current function [A]', 0.15652,
         )
 
     def test_basic_processing_python(self):