Skip to content

Commit

Permalink
#1477 fix idaklu unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
martinjrobins committed Aug 3, 2021
1 parent 073eb58 commit d18cf81
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
7 changes: 5 additions & 2 deletions pybamm/solvers/solution.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,11 @@ def y(self):
@property
def sensitivities(self):
"""Values of the sensitivities. Returns a dict of param_name: np_array"""
if isinstance(self._sensitivities, bool) and self._sensitivities:
self.extract_explicit_sensitivities()
if isinstance(self._sensitivities, bool):
if self._sensitivities:
self.extract_explicit_sensitivities()
else:
self._sensitivities = {}
return self._sensitivities

def set_y(self):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,7 @@ def test_sensitivities(self):
param = pybamm.ParameterValues(chemistry=pybamm.parameter_sets.Ecker2015)
modeltest = tests.StandardModelTest(model, parameter_values=param)
modeltest.test_sensitivities(
#"Negative electrode conductivity [S.m-1]", 14.0
'Typical current [A]', 0.15652,
#"Typical electrolyte concentration [mol.m-3]", 1000.0
#''Negative electrode diffusivity [m2.s-1]', 1e-3,
#'Negative electrode active material volume fraction', 0.372403,
#'Separator thickness [m]', 2e-05,
#'Negative electrode electrons in reaction', 1.0,
#'Outer SEI open-circuit potential [V]', 0.8,
)

def test_basic_processing_1plus1D(self):
Expand Down
1 change: 1 addition & 0 deletions tests/unit/test_solvers/test_idaklu_solver.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ def test_ida_roberts_klu_sensitivities(self):
sol_plus = solver.solve(model, t_eval, inputs={"a": a_value + 0.5 * h})
sol_neg = solver.solve(model, t_eval, inputs={"a": a_value - 0.5 * h})
dyda_fd = (sol_plus.y - sol_neg.y) / h
dyda_fd = dyda_fd.transpose().reshape(-1, 1)

np.testing.assert_array_almost_equal(
dyda_ida, dyda_fd
Expand Down

0 comments on commit d18cf81

Please sign in to comment.