#546 remove macinnes_tplus

examples/scripts/DFN.py

@@ -9,14 +9,13 @@
 
 
 # load model
-model = pybamm.lithium_ion.DFN({"operating mode": "voltage"})
+model = pybamm.lithium_ion.DFN()
 
 # create geometry
 geometry = model.default_geometry
 
 # load parameter values and process model and geometry
 param = model.default_parameter_values
-param.update({"Voltage function [V]": 4.1}, check_already_exists=False)
 param.process_model(model)
 param.process_geometry(geometry)
 

pybamm/input/parameters/lead-acid/electrolytes/sulfuric_acid_Sulzer2019/parameters.csv

@@ -18,7 +18,6 @@ Electrolyte conductivity [S.m-1],[function]conductivity_Gu1997,,
 Darken thermodynamic factor,[function]darken_thermodynamic_factor_Chapman1968,,
 Electrolyte diffusivity [m2.s-1],[function]diffusivity_Gu1997,,
 Electrolyte viscosity [kg.m-1.s-1],[function]viscosity_Chapman1968,,
-MacInnes t_plus function,[function]macinnes_tplus_function,,
 ,,,
 # Other species properties,,,
 Oxygen diffusivity [m2.s-1],2.1e-9,cussler2009diffusion

pybamm/parameters/standard_parameters_lead_acid.py

@@ -514,13 +514,8 @@ def kappa_e(c_e, T):
     return kappa_e_dimensional(c_e_dimensional, T_ref) / kappa_scale
 
 
-def t_plus_function(t_plus):
-    "Function of t_plus in the MacInnes equation"
-    # (1-2*t_plus) is for Nernst-Planck
-    # 2*(1-t_plus) for Stefan-Maxwell
-    return pybamm.FunctionParameter("MacInnes t_plus function", t_plus)
-
-
+# (1-2*t_plus) is for Nernst-Planck
+# 2*(1-t_plus) for Stefan-Maxwell
 def chi(c_e, c_ox=0, c_hy=0):
     return (
         chi_dimensional(c_e_typ * c_e)

pybamm/processed_variable.py

@@ -220,9 +220,6 @@ def initialise_2D(self):
             self.x_sol = first_dim_pts
             self.z_sol = second_dim_pts
         else:
-            import ipdb
-
-            ipdb.set_trace()
             raise pybamm.DomainError(
                 "Cannot process 3D object with domain '{}' "
                 "and auxiliary_domains '{}'".format(self.domain, self.auxiliary_domains)