Skip to content

Commit

Permalink
Merge pull request #2061 from dion-w/patch-1
Browse files Browse the repository at this point in the history
plot voltage components has correct legend order
  • Loading branch information
valentinsulzer authored May 19, 2022
2 parents e992f12 + b6ce3df commit 134585f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

## Bug fixes

- Corrected legend order in "plot_voltage_components.py", so each entry refers to the correct overpotential. ([#2061](https://github.com/pybamm-team/PyBaMM/pull/2061))
- Remove old deprecation errors, including those in `parameter_values.py` that caused the simulation if, for example, the reaction rate is re-introduced manually ([#2022](https://github.com/pybamm-team/PyBaMM/pull/2022))

## Breaking changes
Expand Down
2 changes: 1 addition & 1 deletion pybamm/plotting/plot_voltage_components.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ def plot_voltage_components(
ax.plot(time, V, "k--")
if show_legend:
labels = [
"Voltage",
"Open-circuit voltage",
"Reaction overpotential",
"Concentration overpotential",
"Ohmic electrolyte overpotential",
"Ohmic electrode overpotential",
"Voltage",
]
leg = ax.legend(labels, loc="lower left", frameon=True)
leg.get_frame().set_edgecolor("k")
Expand Down

0 comments on commit 134585f

Please sign in to comment.