-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example/BI Illiteracy #196
Conversation
|
||
fig, ax = plt.subplots(facecolor="white", figsize=[8, 4]) | ||
|
||
sns.stripplot( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to display all non-quantum classifiers on a side, and all quantum classifiers on the other side of the figure?
With a vertical dotted line between them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thanks :) We just need to solve the issue with QSVC. I see it is working correctly with the loans dataset, and I see I have the same problem if I skip the wrapper, and create the pipeline directly with sklearn. Maybe it is just wrongly parametred.
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
Co-authored-by: Quentin Barthélemy <[email protected]>
…ipelline - refactor the example, add more pipelines
- improve label - use placeholders
@toncho11 FYI
QSVM is still able to generalize somehow with other datasets, and we have the results from NBT. So, I guess it is a matter of finding which parameters need to be adapted. |
QSVM accuracy is 100% on the training data. Seems overfitted. |
QSVC codebase significantly changed since the last time we ran QSVC on EEG data. I asked for some help in the qiskit-ml repo, and after checking what I could (simulator, quantum kernel, C, and max_iter) I do not see a problem with QSVC (hard to be 100% confident however).
|
- use complete dataset BI_Il - add hdf5_path
Thanks for the review @qbarthelemy ! |
Issue #8
This is an example of pipeline evaluation with the worst subjects from the Brain Invaders datasets.
The whole dataset took 3 days to run (but in parallel with the simulation for the financial data PR), and eventually failed due to a MOABB bug.
Below you can find an example with the worst subjects of the VR dataset only (6 "subjects").
A few comments:
QuantumSVM
is in fact a classical SVM here. I disabled it because it returned 50% systematically. @toncho11 do you have time to look into it when you come back? From memory, we obtained something around 0.75 with bi2012. This is weird.We can already discuss this example, and proceed to some adjustments before running the whole dataset.
@qbarthelemy FYI