-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/Quantum art visualization #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good.
@@ -98,12 +98,19 @@ def get_mne_sample(n_trials=10, include_auditory=False): | |||
return X, y | |||
|
|||
|
|||
def get_qiskit_dataset(): | |||
def get_qiskit_dataset(n_samples=30): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't be confusing for someone who wants the entire dataset to get only 30 samples when calling the function without parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dataset is generated. So you have to specify somehow the number of samples you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Then the name could be "generate_qiskit_dataset".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good point.
# the variational quantum circuit which is used by VQC. | ||
# | ||
# The idea is simple : | ||
# - We initialize a VQC with different number of parameters and number of samples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add . at the end of this sentence.
# | ||
# The idea is simple : | ||
# - We initialize a VQC with different number of parameters and number of samples | ||
# - We train the VQC a couple of time and we store the fitted weights. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
time -> times
# The idea is simple : | ||
# - We initialize a VQC with different number of parameters and number of samples | ||
# - We train the VQC a couple of time and we store the fitted weights. | ||
# - We compute variability of the weight and display it in a fashion way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fashion -> fashionable
This is a PR, which explores a topic of quantum computing called quantum art, that is, some kind of artistic visualization of quantum.
We can find some examples here, where noise inside quantum calculation is used to generate bubbles. The number of bubbles and the size of each bubble then directly depend on the noise model inside the quantum computer.
In this PR, the fitted weight of the variational circuit inside VQC is displayed in a spiral. The number of "branches" in the spiral depends on the number of parameters, and the "larger" of each branch depends on the variability of the weights.