-
Notifications
You must be signed in to change notification settings - Fork 19
Consistent logging #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent logging #270
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 80.22% 80.38% +0.16%
==========================================
Files 10 11 +1
Lines 713 724 +11
Branches 92 92
==========================================
+ Hits 572 582 +10
- Misses 131 132 +1
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this approach @banesullivan. Will give a more thorough review when it is out of draft. Thank you!
except urllib.error.URLError as url_error: | ||
print("Oops - can find the url", file_path, url_error) | ||
except urllib.error.URLError: | ||
logger.error(f"Oops - can find the url: {file_path}", exc_info=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logger.error(f"Oops - can find the url: {file_path}", exc_info=True) | |
logger.error(f"Oops - I can't find the url: {file_path}", exc_info=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for cleaning this up @banesullivan let's merge.
Make logging/debug statements consistently use a logger.
Note: we want to use
logging
overwarnings
aswarnings
will suppress a warning after the first time it is issued. When processing reviews, we want to see any warnings that are issued on a project by project basisThis also adds
tqdm
for progress monitoring