Skip to content

[hotfix] handle packages that lack a description on GitHub #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

banesullivan
Copy link
Contributor

@banesullivan banesullivan commented Feb 15, 2025

Hotfix for pyOpenSci/pyopensci.github.io#560

The issue is that astrodata does not have a description on GitHub so the API returns null and our GhMeta Pydantic model requires this field be set to some string. Considering that repositories on GitHub don't have to have a description, I have changed the description field to be optional.

I also added a few other print statements to our routines to make it a little ore obvious what is going on. A few people had looked at the CI logs and thought Earthpy must be the issue since it was the last logged package. However that was from the previous processing step and the gh-metrics step was running across all packages without any indication.

This PR is meant as a hotfix to get CI back up and running but there are a few things I want to do to improve this which I will post in pyOpenSci/pyopensci.github.io#560

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.27%. Comparing base (55876aa) to head (26c5ad2).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/pyosmeta/parse_issues.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
- Coverage   76.38%   76.27%   -0.11%     
==========================================
  Files          10       10              
  Lines         724      725       +1     
  Branches       92       92              
==========================================
  Hits          553      553              
- Misses        161      162       +1     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Let's get this up and running.

Someday in the future we may wish to migrate the print statements to logging but not important today.

@willingc willingc merged commit 7df203f into pyOpenSci:main Feb 15, 2025
4 checks passed
@pllim
Copy link
Contributor

pllim commented Feb 17, 2025

Thanks! Is there something else that needs to be done for the 4th package to show up at https://www.pyopensci.org/communities/astropy.html ? 🙏 🙇‍♀️

@banesullivan
Copy link
Contributor Author

I think we just need to issue a release for pyosmeta so that this new version is picked up by this workflow and then the site will be updated

@banesullivan
Copy link
Contributor Author

And that release to pypi is waiting on @lwasser's approval in https://github.com/pyOpenSci/pyosMeta/actions/runs/13348330244

Screenshot 2025-02-16 at 9 57 29 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants