-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Adding intervention graph classes for known graphs and equivalence classes and improve graph class documentation #49
Conversation
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 83.46% 84.03% +0.57%
==========================================
Files 29 29
Lines 2147 2255 +108
Branches 558 578 +20
==========================================
+ Hits 1792 1895 +103
- Misses 253 254 +1
- Partials 102 106 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Whenever you guys get the chance, if either of you are familiar enough w/ the intervention graphs to provide a review, it would be very helpful! The corresponding implementation of PsiFCI with known and unknown intervention targets is implemented in py-why/dodiscover#111 |
@jaron-lee and @robertness lmk if you guys prefer to take a review before I merge. Just cuz I need it in However, think some reviews is good at least to get the team acquainted |
Ima go ahead and merge this to get PsiFCI working and get us closer to just a v0.1 for pywhy-graphs. We can open up an issue to address whether there are concerns w/ implementation. |
Signed-off-by: Adam Li [email protected]
Xref PR implementing the PsiFCI algorithm: py-why/dodiscover#111
Changes proposed in this pull request:
AugmentedGraph
,IPAG
andPsiPAG
with minimal code-duplicationpywhy_graphs/classes/intervention.py
Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.After submitting