Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Adding intervention graph classes for known graphs and equivalence classes and improve graph class documentation #49

Merged
merged 18 commits into from
Feb 23, 2023

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Feb 9, 2023

Signed-off-by: Adam Li [email protected]

Xref PR implementing the PsiFCI algorithm: py-why/dodiscover#111

Changes proposed in this pull request:

  • Implements AugmentedGraph, IPAG and PsiPAG with minimal code-duplication
  • Adds unit tests on the F-nodes
  • Adds documentation details to ADMG, CPDAG and PAG that addresses some of the shortcomings described in [BUG] R8 does a check for a tail incorrectly dodiscover#114
  • the main file to review is pywhy_graphs/classes/intervention.py

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

pywhy_graphs/classes/intervention.py Outdated Show resolved Hide resolved
pywhy_graphs/classes/intervention.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #49 (aab9681) into main (4e9cef8) will increase coverage by 0.57%.
The diff coverage is 89.56%.

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   83.46%   84.03%   +0.57%     
==========================================
  Files          29       29              
  Lines        2147     2255     +108     
  Branches      558      578      +20     
==========================================
+ Hits         1792     1895     +103     
- Misses        253      254       +1     
- Partials      102      106       +4     
Impacted Files Coverage Δ
pywhy_graphs/algorithms/generic.py 85.57% <ø> (ø)
pywhy_graphs/algorithms/pag.py 91.02% <ø> (ø)
pywhy_graphs/classes/admg.py 95.12% <ø> (ø)
pywhy_graphs/classes/cpdag.py 83.67% <ø> (ø)
pywhy_graphs/classes/pag.py 82.25% <ø> (ø)
pywhy_graphs/networkx/classes/mixededge.py 90.00% <62.50%> (-0.85%) ⬇️
pywhy_graphs/classes/intervention.py 91.89% <91.58%> (+91.89%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adam2392 adam2392 changed the title [ENH] Adding intervention graph classes for known graphs and equivalence classes [ENH] Adding intervention graph classes for known graphs and equivalence classes and improve graph class documentation Feb 14, 2023
Signed-off-by: Adam Li <[email protected]>
@adam2392 adam2392 added this to the Release v0.1 milestone Feb 15, 2023
@adam2392
Copy link
Collaborator Author

Signed-off-by: Adam Li <[email protected]>
@adam2392
Copy link
Collaborator Author

Whenever you guys get the chance, if either of you are familiar enough w/ the intervention graphs to provide a review, it would be very helpful!

The corresponding implementation of PsiFCI with known and unknown intervention targets is implemented in py-why/dodiscover#111

@adam2392
Copy link
Collaborator Author

@jaron-lee and @robertness lmk if you guys prefer to take a review before I merge. Just cuz I need it in main for dodiscover Psi-FCI PR.

However, think some reviews is good at least to get the team acquainted

@adam2392
Copy link
Collaborator Author

adam2392 commented Feb 23, 2023

Ima go ahead and merge this to get PsiFCI working and get us closer to just a v0.1 for pywhy-graphs. We can open up an issue to address whether there are concerns w/ implementation.

@adam2392 adam2392 merged commit c387f8a into py-why:main Feb 23, 2023
@adam2392 adam2392 deleted the intervention branch February 23, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants