Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add __iter__() for TableList to support enumerate() #13

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Conversation

stonyw
Copy link

@stonyw stonyw commented Mar 19, 2024

    tables = camelot.read_pdf(filename)
    for idx, table in enumerate(tables):   # Warining: Expected type 'Iterable[_T]', got 'TableList' instead  in pycharm
        pass

@stefan6419846
Copy link

Are you able to provide a corresponding test as well?

@foarsitter
Copy link
Collaborator

I agree with @stefan6419846, your provided example is almost a test-case. Whilst the improvement looks very trivial a test-case is easy to provide.

@stonyw
Copy link
Author

stonyw commented Mar 21, 2024

I'll add tests soon.

@bosd bosd merged commit e323cde into py-pdf:main Aug 10, 2024
9 of 11 checks passed
@bosd bosd added the enhancement New feature or request label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants