Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Actions are broken #542

Open
elyscape opened this issue May 5, 2020 · 7 comments
Open

Web Actions are broken #542

elyscape opened this issue May 5, 2020 · 7 comments

Comments

@elyscape
Copy link
Contributor

elyscape commented May 5, 2020

Describe the bug
The master build of PWM can't save Web Actions to the config file and can't read ones added manually. This results in Web Actions being completely broken.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the configuration editor.
  2. Click Modules -> Authenticated -> Change Password. Note that, while these steps are for the Change Password action, this also applies to everything else that supports Web Actions.
  3. Under "Post Password Change Actions", click "Add Action".
  4. Type testaction and click "OK".
  5. Click the "Actions" button next to "testaction".
  6. Click "Add Web Service Action".
  7. Type http://google.com and click "OK" twice.
  8. Save the configuration.
  9. Go back to the configuration editor.
  10. Click Modules -> Authenticated -> Change Password.
  11. Click the "Actions" button next to "testaction".
  12. Look at the value in PwmConfiguration.xml for changePassword.writeAttributes.

Expected behavior
The configured action should remain configured in the UI. The value of changePassword.writeAttributes should be:

{"name":"testaction","description":"","webActions":[{"method":"get","headers":{},"url":"http://google.com","body":"","username":"","password":"","successStatus":[200]}],"ldapActions":[]}

Actual behavior
The configured action vanishes from the UI. The value of changePassword.writeAttributes becomes:

{"name":"testaction","description":"","webActions":[],"ldapActions":[]}

Additional context
This does not affect version 1.9.1. I haven't done a whole lot of digging, but it seems likely to have been introduced during the stored configuration refactoring during November 2019.

@jrivard
Copy link
Contributor

jrivard commented May 7, 2020

Is this not fixed by commit dd4ce03 in pull request #541 ? If not I can't reproduce it...

@elyscape
Copy link
Contributor Author

elyscape commented May 8, 2020

That should have been unrelated but I’ll test with that build.

@elyscape
Copy link
Contributor Author

The issue remains with that build.

@elyscape
Copy link
Contributor Author

Additional details: adding a Web Service Action to an existing change action does not cause it to show in the change summary when going to save the configuration changes.

@bjustice0387
Copy link

I had this same issue and had to go back to v1.9.1. I am getting "A required service is unavailable. Please try again later." in v1.9.1.

@jrivard
Copy link
Contributor

jrivard commented Jun 4, 2022

@jrivard
Copy link
Contributor

jrivard commented Jun 4, 2022

I have been able to reproduce this issue in v2.0.1. From my testing it fails when a basic auth password value is not included. If a basic auth password is included, the save and reload works fine.

jrivard added a commit that referenced this issue Jun 4, 2022
…h password value isn't included in setting value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants