DMAPP-125: Chat reaction feature #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the
In the
After making the above corrections and improvements, the code seems to be in good shape. All looks good. |
|
In the Globals.ts file, there are some mistakes in color values where the decimals are not correctly separated from integers:
In MessageComponent.tsx:
Other than those mentioned above, the code looks good. All looks good. |
…ent in socket listener
|
In the Globals.ts file:
In the MessageComponent.tsx file:
Overall, the code needs some fixes and improvements. Let me tidy up the code: // In Globals.ts:
All looks good.
// In MessageComponent.tsx:
- Remove the unnecessary 'handleMessageLongPress' function.
- Fix the syntax error in the messageType ternary operation.
- Add the missing closing bracket for the 'handleReply' function.
- Add missing closing brackets at the end of the file.
// Other files have not been reviewed for feedback. |
rohitmalhotra1420
requested changes
Nov 7, 2024
| reactionPickerId={activeReactionMessageId} | ||
| handleTapOutside={() => handleTapOutside()} | ||
| sendReaction={handleSendReaction} | ||
| chatReactions={reactionMessages?.[(item as any).cid] || []} |
There was a problem hiding this comment.
Suggested change
| chatReactions={reactionMessages?.[(item as any).cid] || []} | |
| chatReactions={reactionMessages?.[(item as Type).cid] || []} |
Comment on lines
32
to
33
| sendReaction?: (reactionPayload: any) => void; | ||
| chatReactions?: any; |
There was a problem hiding this comment.
Suggested change
| sendReaction?: (reactionPayload: any) => void; | |
| chatReactions?: any; | |
| sendReaction?: (reactionPayload:Type) => void; | |
| chatReactions?:Type; |
|
|
||
| const Reactions: FC<ReactionsProps> = ({chatReactions, componentType}) => { | ||
| // transform to IReactions | ||
| const uniqueReactions = chatReactions.reduce((acc: any, reaction: any) => { |
There was a problem hiding this comment.
Suggested change
| const uniqueReactions = chatReactions.reduce((acc: any, reaction: any) => { | |
| const uniqueReactions = chatReactions.reduce((acc: Type, reaction:Type) => { |
| </Text> | ||
| </View> | ||
| ) : ( | ||
| Object.entries(uniqueReactions).map(([content, reactions]: any[]) => ( |
There was a problem hiding this comment.
Suggested change
| Object.entries(uniqueReactions).map(([content, reactions]: any[]) => ( | |
| Object.entries(uniqueReactions).map(([content, reactions]: Type[]) => ( |
| @@ -78,6 +80,11 @@ const useSendMessage = ( | |||
| content: message, | |||
| }; | |||
|
|
|||
| if (reactionRef !== undefined) { | |||
There was a problem hiding this comment.
Suggested change
| if (reactionRef !== undefined) { | |
| if (reactionRef) { |
|
All looks good. |
|
All looks good. |
rohitmalhotra1420
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature integration]: Add reaction support in chat and show reply button on message long press.