Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMAPP-122: Common header changes done #126

Merged
merged 1 commit into from
Oct 28, 2024
Merged

DMAPP-122: Common header changes done #126

merged 1 commit into from
Oct 28, 2024

Conversation

meKushdeepSingh
Copy link
Collaborator

@meKushdeepSingh meKushdeepSingh commented Oct 23, 2024 •
edited
Loading

New Design
Image

Changes Made:

  • Integrated UI changes for the common header.
  • Retained the Header component and implemented the new changes within it.
  • Removed the Channels Header component file.

@meKushdeepSingh meKushdeepSingh self-assigned this Oct 23, 2024
@meKushdeepSingh meKushdeepSingh linked an issue Oct 23, 2024 that may be closed by this pull request
Make header consistent for all screens. E.g preferred header is on Channels Page #122
Closed
rohitmalhotra1420
rohitmalhotra1420 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@rohitmalhotra1420 rohitmalhotra1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out. Looks fine to me.

@rohitmalhotra1420 rohitmalhotra1420 merged commit 095c62a into main Oct 28, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitmalhotra1420 rohitmalhotra1420 rohitmalhotra1420 approved these changes

Assignees

@meKushdeepSingh meKushdeepSingh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make header consistent for all screens. E.g preferred header is on Channels Page
2 participants
@meKushdeepSingh @rohitmalhotra1420