Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle Infura APIs based on application environment #117

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

meKushdeepSingh
Copy link
Collaborator

This PR addresses the handling of Infura APIs according to the application environment (staging and production). It ensures that the appropriate Infura API & project IDs are used based on the environment configuration.

Copy link

  • The variable name SHOW_CONSOLE is misleading, it's not about showing or disabling console, it should be renamed to something more descriptive.

  • There is a typo in the comment All Server related endpoints, it should be All server-related endpoints.

  • In the third-party services section, CNS_ENDPOINT seems to be undefined. Make sure it is imported correctly, or define it if it's supposed to be a constant.

  • The assignment of ENDPOINT_ICE_SERVERS is missing a value to assign.

  • The logic for CHAIN_ID seems potentially incorrect. Make sure it's supposed to have the value 1 for prod and 11155111 for staging.

  • It's a good practice to use descriptive key names for objects. Consider renaming DAPP_URL to something more informative.

  • The variable GC_RPC appears to be used, but it's not defined in the code provided. Ensure it is defined or removed if unnecessary.

  • In the last line, the spread operator {...PROD_CONTRACTS} and {...STAGING_CONTRACTS} are used inside curly braces. This syntax is not correct for spreading objects. It should be spread without curly braces.

After addressing these issues, the code should be reviewed again for further improvements as necessary. If everything is corrected, please write 'All looks good.'

@rohitmalhotra1420 rohitmalhotra1420 merged commit 25b56d5 into main Oct 16, 2024
1 check passed
Copy link

gitpoap-bot bot commented Oct 16, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Push Protocol Contributor:

GitPOAP: 2024 Push Protocol Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@rohitmalhotra1420 rohitmalhotra1420 linked an issue Oct 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new Infura project ids for staging and prod env
2 participants