Refactor internal environments handling #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we handle "app environments" internally, switching from using custom typeclasses to
generic-lensto access resources at runtime.A similar refactoring happened in #610, but that left a few wonky corners, which we take care of here:
BuildEnvright away when bundling, but only if it's needed to actually build-c skipis used #704 by properly skipping it when desiredThis PR also includes a breaking change: we remove the
spago logincommand, as it's unused now and will be unnecessary in the future. This should have a very low impact, as no one has any reason to use this command right now